Skip to content

Comments

gh-144777: Fix data races in IncrementalNewlineDecoder#144971

Merged
colesbury merged 1 commit intopython:mainfrom
colesbury:gh-144777-newline-decoder-data-race
Feb 23, 2026
Merged

gh-144777: Fix data races in IncrementalNewlineDecoder#144971
colesbury merged 1 commit intopython:mainfrom
colesbury:gh-144777-newline-decoder-data-race

Conversation

@colesbury
Copy link
Contributor

@colesbury colesbury commented Feb 18, 2026

Add critical sections to methods of IncrementalNewlineDecoder to prevent concurrent access to shared bitfields (pendingcr, seennl).

Add critical sections to methods of IncrementalNewlineDecoder to
prevent concurrent access to shared bitfields (pendingcr, seennl).
Copy link
Contributor

@mpage mpage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@colesbury colesbury merged commit 8db8fc9 into python:main Feb 23, 2026
57 checks passed
@colesbury colesbury deleted the gh-144777-newline-decoder-data-race branch February 23, 2026 14:32
@miss-islington-app
Copy link

Thanks @colesbury for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @colesbury, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 8db8fc9b51060b61d14fbe6aa0f2e2591292279e 3.14

colesbury added a commit to colesbury/cpython that referenced this pull request Feb 23, 2026
…ythongh-144971)

(cherry picked from commit 8db8fc9)

Co-authored-by: Sam Gross <colesbury@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Feb 23, 2026

GH-145143 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Feb 23, 2026
@colesbury colesbury removed their assignment Feb 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants